Coding Standards for CppCMS 1.x.x
Coding Style
- Indentation: — K&R only.
Naming: use small_letters_and_underscore. Such names are much more readable. Same namging convention for class names, variables and functions. NeverUseUglyAndUnreadableCamelCasedCode. Rationale – readability.
Prefer to use STL conventions. For example, for cleanup operations use
clear(), for finding something "find()" and so on.- Polish/Hungarian notations are not in CppCMS. No prefixes or suffixes like
iNumberorm_some_class_member. Variable Names: — variables like
i,j,tmpare perfrectly well to use inside functions, in loops. It is ok to usedef,tmpperfixes and suffixes for member variables when they meaning something.Rationale: Linux Kernel Coding Style.
Class Members: are ended with underscore
_with exception of public structure members that do not have suffixes/prefixes. Rationale - Boost.Tab Stops — Tab is 8, not 4, not 2 and defiantly not 5! Tab width=8 is like Pi=3.1415926535. Do not use something else. This is most compatible over different editors, it is standard, it should be used anywhere. It makes code more readable at 1:00am.
Do not replace tabs with spaces, all indentation should be done with tabs.
Rationale: Linux Kernel Coding Style
Preprocessor Macros — should be CAPITAL_CASED_WITH_UNDERSCORES. Always add
CPPCMS_prefix to them.
General Coding Notes
Exceptions
All code you write should be exception safe. Only functions that you may assume they never throw exceptions are POSIX API or 3rd party C libraries like libgcrypy or sqlite3. Even STL may throw exception. Assume that std::bad_alloc may be thrown and handle it correctly.
Thus:
Always use smart pointers. Prefer auto_ptr over reference counting smart pointers:
- It is faster and does not include ref-counting overheads
- All of them can be always created from auto_ptr but not in other direction.
- It has move semantics that covers our requirements in most of cases:
For example
auto_ptr<my_class> my_func() { auto_ptr<my_class> instance(new my_class); instance->do_something(); return instance; }Use std::vector instead of allocating
new some_class[N].- When using C API, that does not have destructors, put your code inside try-catch block and cleanup everything.
- If you use C API in more then one place consider wrapping it with simple class or at least provide scoped destructor. See as an example posix_mutex.h or fcntl_mutex.h
STL
Do not reinvent the wheel, use STL — it is well document, well known, highly available library that does the job. Use it.
Notes:
- Always prefer std::vector to std::list — it has better performance because it is cache friendly.
- Always prefer std:string for text storage.
- It is OK to return STL collections from functions, compiler know how to optimize them.
Do not forget
swap()function — it can save lot’s of unnecessary copies for you. For example:vector<char> foo(); ... void bar() { vector<char> s; for(;;) { s.swap(foo()); // Not s=foo(); if(s.empty()) break; } }Description: when you calls=foo()assignment operator is called that copies the value thatfoo()returned tosand then releases it. When you calls.swap(foo())the value insis replaced by returned value and the old value insis cleaned — you saved copy of probably huge buffer, you operation is done inO(1).- If you have non-copyable class, you can store it in STL collection using reference counting pointer.
Libraries
Boost
CppCMS should work with at least Boost 1.37.
Generally prefer boost over other libraries, however use Boost features carefully, or do not use at all. Examples:
Boost Interprocess too "heavy" and little bit "ugly" because it supports windows and supports placing any objects in memory. The nature of
fork()gives much better functionality and allows placing any object in shared memory every time it use shared memory allocators.So use it only as replacement of libmm.
Boost Serialization – has too many performance overheads – don’t use it.
Licenses
- All libraries should be OpenSource libraries
- Prefer non-copyleft licenses like MIT, 3 clause BSD, Boost over copyleft one, like LGPL.
- All libraries, CppCMS uses should be compatible with LGPLv2.
You may use strong copyleft libraries for stand alone utilities that are not linked with CppCMS framework.
For example: If you want to write GUI for
cppcms_tcp_scaleutility using Qt you are welcome.
Using
If you want to add an additional dependency for CppCMS make sure:
- Check if boost has implementation of such feature.
- There is a big value for adding such dependency.
- This library is highly available.
- You checked all alternatives and decided that this one is the best.
- You had added an autoconf macro and conditional build for CppCMS that allows building all framework without this library.
For example, libgcrypt:
- You need high quality library to encrypt cookies, home made solutions are too dangerous.
- This library is available for almost any UNIX platform.
- Other alternatives like OpenSSL has problematic license and bad documentation.
- If you do not have libgcrypt, you still have simple digitally signed cookies that are still safe.